Cygnus issueshttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues2018-01-22T11:30:29Zhttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/4Allow the use of the watchlist2018-01-22T11:30:29ZLuke081515luke081515@tools.wmflabs.orgAllow the use of the watchlistIn general you can track changes with the watchlist. It can be useful to use this feature. We should:
* [x] create a function that allows watching and unwatching of pages
* [x] make sure that no other functions are watching or unwatching pages
* [ ] create a function that reads out the watchlistIn general you can track changes with the watchlist. It can be useful to use this feature. We should:
* [x] create a function that allows watching and unwatching of pages
* [x] make sure that no other functions are watching or unwatching pages
* [ ] create a function that reads out the watchlistVersion 2.2https://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/7Get a uniform format for API-Urls2017-12-19T00:04:54ZLuke081515luke081515@tools.wmflabs.orgGet a uniform format for API-UrlsWhen formatting an API URL there are several ways at the moment, one is putting all the extra rubish in one line. That's not that readable, additionally phpcs freaks out when it sees that. So we need a good way to format all these URLs. What format do you prefer?
I prefer something like:
```
$data = 'action=watch'
. '&format=json'
. '&unwatch=' . $unwatch
. '&titles=' . urlencode($title)
. '&token=' . urlencode($token)
. '&assert=' . $this->assert
. '&maxlag=' . $this->maxlag;
```
(From merge request 5)
Easy to read, but tends to get long.When formatting an API URL there are several ways at the moment, one is putting all the extra rubish in one line. That's not that readable, additionally phpcs freaks out when it sees that. So we need a good way to format all these URLs. What format do you prefer?
I prefer something like:
```
$data = 'action=watch'
. '&format=json'
. '&unwatch=' . $unwatch
. '&titles=' . urlencode($title)
. '&token=' . urlencode($token)
. '&assert=' . $this->assert
. '&maxlag=' . $this->maxlag;
```
(From merge request 5)
Easy to read, but tends to get long.Version 2.2https://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/14Write automatic tests for each function2017-11-09T15:12:30ZLuke081515luke081515@tools.wmflabs.orgWrite automatic tests for each functionIt would be great if we can build a script which checks every function against each single return possiblity, and then submit this script to the pipeline for each new commit.It would be great if we can build a script which checks every function against each single return possiblity, and then submit this script to the pipeline for each new commit.Version 2.2Luke081515luke081515@tools.wmflabs.orgLuke081515luke081515@tools.wmflabs.orghttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/15Collect return possiblitys for each function2018-01-30T12:30:34ZLuke081515luke081515@tools.wmflabs.orgCollect return possiblitys for each functionTo check 2.1 when it's finished and for #14 I need a list of every return result and a test for each method. For example:
* `checkUserExistence()`
* `return false` => User does not exist
* `return true` => User does exist
In case that there are methods which are using variable outputs, like editcount, then please write something like this:
* `checkUserEditcount()`
* `return false` => User does not exist
* `return (example) 1152` => User has the editcount 1152 (example)To check 2.1 when it's finished and for #14 I need a list of every return result and a test for each method. For example:
* `checkUserExistence()`
* `return false` => User does not exist
* `return true` => User does exist
In case that there are methods which are using variable outputs, like editcount, then please write something like this:
* `checkUserEditcount()`
* `return false` => User does not exist
* `return (example) 1152` => User has the editcount 1152 (example)Version 2.2https://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/28Generate CodeCoverage Report2018-01-10T21:30:29ZLuke081515luke081515@tools.wmflabs.orgGenerate CodeCoverage ReportIt would be nice if pipeline can generate a CodeCoverage report, phpunit supports that, but needs to be configured.It would be nice if pipeline can generate a CodeCoverage report, phpunit supports that, but needs to be configured.Version 2.2https://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/32General handling for warnings2017-11-09T14:27:53ZLuke081515luke081515@tools.wmflabs.orgGeneral handling for warningsAs seen in #31 it would be nice if we can display or log warnings. In this case I discovered that problem only because I ran debug with the new verbose-debug mode. That is optimal, as warnings may useful as well for the developers. Additionally, if we are handling warnings better, we can make unit tests fail as well.
What's better, displaying or logging warnings? And at which place to we want to catch them? Each function or maybe httpRequest? httpRequest has the problem of different formats, if old functions are using format=php, httpRequest can't search for the json part. Or implement an extra function for that?
@freddy2001 Your thoughts?As seen in #31 it would be nice if we can display or log warnings. In this case I discovered that problem only because I ran debug with the new verbose-debug mode. That is optimal, as warnings may useful as well for the developers. Additionally, if we are handling warnings better, we can make unit tests fail as well.
What's better, displaying or logging warnings? And at which place to we want to catch them? Each function or maybe httpRequest? httpRequest has the problem of different formats, if old functions are using format=php, httpRequest can't search for the json part. Or implement an extra function for that?
@freddy2001 Your thoughts?Version 2.2FreddyFreddyhttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/33make the bot able to read/write from wikibase2018-01-30T22:29:41ZLuke081515luke081515@tools.wmflabs.orgmake the bot able to read/write from wikibaseoriginally from https://rcm-2.wmflabs.org/T905
The bot should be able to interact with wikibase. Not sure if we should insert that into BotCore or write a seperate class.originally from https://rcm-2.wmflabs.org/T905
The bot should be able to interact with wikibase. Not sure if we should insert that into BotCore or write a seperate class.FreddyFreddyhttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/39All write methods should check AllowBots2017-12-19T00:04:40ZLuke081515luke081515@tools.wmflabs.orgAll write methods should check AllowBotsWe have already `AllowBots()`, it's checking pages, if editing them. But we should also check on deleting, protecting etc.We have already `AllowBots()`, it's checking pages, if editing them. But we should also check on deleting, protecting etc.Version 2.2https://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/41Implement massmessage2017-12-20T21:33:13ZLuke081515luke081515@tools.wmflabs.orgImplement massmessageAPI-function massmessage should be implementedAPI-function massmessage should be implementedVersion 2.2https://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/43Implement function "revisiondelete"2017-12-20T21:35:21ZLuke081515luke081515@tools.wmflabs.orgImplement function "revisiondelete"Write a function to use that API-functionWrite a function to use that API-functionVersion 2.2https://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/45Implement function "setPageLanguage"2017-12-20T21:36:56ZLuke081515luke081515@tools.wmflabs.orgImplement function "setPageLanguage"Should be implemented to use that functionShould be implemented to use that functionVersion 2.2https://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/46Implement function "clientlogin"2017-12-20T21:38:45ZLuke081515luke081515@tools.wmflabs.orgImplement function "clientlogin"To support logging in via normal data without botpasswords.To support logging in via normal data without botpasswords.Version 2.2https://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/47Implement function "prop=deletedrevisions"2017-12-20T21:39:50ZLuke081515luke081515@tools.wmflabs.orgImplement function "prop=deletedrevisions"It should be possible to query deleted versionsIt should be possible to query deleted versionsVersion 2.2https://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/48Implement function "fileusage" / "globalusage"2017-12-20T21:40:44ZLuke081515luke081515@tools.wmflabs.orgImplement function "fileusage" / "globalusage"for querying file datafor querying file dataVersion 2.2https://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/49Implement function "pro=pageviews"2017-12-20T21:41:40ZLuke081515luke081515@tools.wmflabs.orgImplement function "pro=pageviews"Version 2.2https://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/50Implement function "list=alldeletedrevisions"2017-12-20T21:42:49ZLuke081515luke081515@tools.wmflabs.orgImplement function "list=alldeletedrevisions"For usage like: get all deleted revisions where the author is user xFor usage like: get all deleted revisions where the author is user xVersion 2.2https://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/51Implement list=checkuser / list=checkuserlog2017-12-20T21:43:24ZLuke081515luke081515@tools.wmflabs.orgImplement list=checkuser / list=checkuserlogVersion 2.2https://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/52Implement list=logevents2017-12-20T21:44:19ZLuke081515luke081515@tools.wmflabs.orgImplement list=logeventsto read out logs etc.to read out logs etc.Version 2.2https://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/53Implement list=usercontrib2017-12-20T21:45:46ZLuke081515luke081515@tools.wmflabs.orgImplement list=usercontribVersion 2.2https://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/56Write tutorial for Cygnus2017-12-25T22:21:14ZFreddyWrite tutorial for CygnusA tutorial with the basic functions of Cygnus (read, edit, ...) would be helpful for someA tutorial with the basic functions of Cygnus (read, edit, ...) would be helpful for some