Cygnus issueshttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues2018-01-31T21:36:41Zhttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/67Debug: let the user retry2018-01-31T21:36:41ZLuke081515luke081515@tools.wmflabs.orgDebug: let the user retryIf you need to specify the function to debug, and you mistyped it, it would be useful if you can try it again without needing to relogin.If you need to specify the function to debug, and you mistyped it, it would be useful if you can try it again without needing to relogin.Version 2.1Luke081515luke081515@tools.wmflabs.orgLuke081515luke081515@tools.wmflabs.orghttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/70ban goto2018-01-31T21:36:40ZLuke081515luke081515@tools.wmflabs.orgban gotoIt would be useful to ban this not so good piece of coding, which is only used at some places.It would be useful to ban this not so good piece of coding, which is only used at some places.Version 2.1Luke081515luke081515@tools.wmflabs.orgLuke081515luke081515@tools.wmflabs.orghttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/20Move API path to Password.php2018-01-31T21:36:40ZFreddyMove API path to Password.phpThe path to API (usually w/api.php) should be set in Password.php because it may differ on some wikis i.e. Wikia projectsThe path to API (usually w/api.php) should be set in Password.php because it may differ on some wikis i.e. Wikia projectsVersion 2.1FreddyFreddyhttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/74BlockGlobal can not handle errors2018-01-16T21:05:14ZLuke081515luke081515@tools.wmflabs.orgBlockGlobal can not handle errors```
Give me the IP:<already blocked ip>
PHP Notice: Undefined index: code in /home/luke/Scripts/Cygnus/BotCore.php on line 1283
PHP Stack trace:
PHP 1. {main}() /home/luke/Scripts/GlobalMassBlock.php:0
PHP 2. GlobalMassBlock->__construct() /home/luke/Scripts/GlobalMassBlock.php:24
PHP 3. GlobalMassBlock->blockGlobal() /home/luke/Scripts/GlobalMassBlock.php:15
Not blocked!
``````
Give me the IP:<already blocked ip>
PHP Notice: Undefined index: code in /home/luke/Scripts/Cygnus/BotCore.php on line 1283
PHP Stack trace:
PHP 1. {main}() /home/luke/Scripts/GlobalMassBlock.php:0
PHP 2. GlobalMassBlock->__construct() /home/luke/Scripts/GlobalMassBlock.php:24
PHP 3. GlobalMassBlock->blockGlobal() /home/luke/Scripts/GlobalMassBlock.php:15
Not blocked!
```Version 2.1Luke081515luke081515@tools.wmflabs.orgLuke081515luke081515@tools.wmflabs.orghttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/72Check if a page contains a template2018-01-16T21:05:14ZLuke081515luke081515@tools.wmflabs.orgCheck if a page contains a templateWrite a function that checks if a template is present on a page.Write a function that checks if a template is present on a page.Version 2.1Luke081515luke081515@tools.wmflabs.orgLuke081515luke081515@tools.wmflabs.orghttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/31login: Deprecated: Show warning2018-01-16T21:05:14ZLuke081515luke081515@tools.wmflabs.orglogin: Deprecated: Show warningResult for `action=login&maxlag=5&format=json&lgname=Luke081515Bot&lgpassword=redacted&lgtoken=sometoken`:
```json
'{"warnings":{"main":{"*":"Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce> for notice of API deprecations and breaking changes. Use [[Special:ApiFeatureUsage]] to see usage of deprecated features by your application."},"login":{"*":"Main-account login via \"action=login\" is deprecated and may stop working without warning. To continue login with \"action=login\", see [[Special:BotPasswords]]. To safely continue using main-account login, see \"action=clientlogin\"."}},"login":{"result":"Success","lguserid":294,"lgusername":"Luke081515Bot"}}'
```
You don't get this, if you are doing a login via botpasswords.
So what is our plan here? Warn users using login and normal password, and support clientlogin?Result for `action=login&maxlag=5&format=json&lgname=Luke081515Bot&lgpassword=redacted&lgtoken=sometoken`:
```json
'{"warnings":{"main":{"*":"Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce> for notice of API deprecations and breaking changes. Use [[Special:ApiFeatureUsage]] to see usage of deprecated features by your application."},"login":{"*":"Main-account login via \"action=login\" is deprecated and may stop working without warning. To continue login with \"action=login\", see [[Special:BotPasswords]]. To safely continue using main-account login, see \"action=clientlogin\"."}},"login":{"result":"Success","lguserid":294,"lgusername":"Luke081515Bot"}}'
```
You don't get this, if you are doing a login via botpasswords.
So what is our plan here? Warn users using login and normal password, and support clientlogin?Version 2.1Luke081515luke081515@tools.wmflabs.orgLuke081515luke081515@tools.wmflabs.orghttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/62readPage fails to identify missing pages2018-01-13T22:33:44ZLuke081515luke081515@tools.wmflabs.orgreadPage fails to identify missing pages```
Result for action=query&prop=revisions&format=json&rvprop=content&rvlimit=1&rvcontentformat=text%2Fx-wiki&titles=User%3Asgfdsfsd&rvdir=older&assert=bot&maxlag=5&rawcontinue=&indexpageids=1:
'{"query":{"normalized":[{"from":"User:sgfdsfsd","to":"Benutzer:Sgfdsfsd"}],"pageids":["-1"],"pages":{"-1":{"ns":2,"title":"Benutzer:Sgfdsfsd","missing":""}}}}'PHP Notice: Undefined index: revisions in /home/luke/Cygnus/BotCore.php on line 356
PHP Stack trace:
PHP 1. {main}() /home/luke/Cygnus/Debug.php:0
PHP 2. Debug->__construct() /home/luke/Cygnus/Debug.php:715
PHP 3. Debug->debug() /home/luke/Cygnus/Debug.php:24
PHP 4. Debug->readPage() /home/luke/Cygnus/Debug.php:40
PHP 5. Debug->readPageEngine() /home/luke/Cygnus/BotCore.php:369
Function call succeeded
``````
Result for action=query&prop=revisions&format=json&rvprop=content&rvlimit=1&rvcontentformat=text%2Fx-wiki&titles=User%3Asgfdsfsd&rvdir=older&assert=bot&maxlag=5&rawcontinue=&indexpageids=1:
'{"query":{"normalized":[{"from":"User:sgfdsfsd","to":"Benutzer:Sgfdsfsd"}],"pageids":["-1"],"pages":{"-1":{"ns":2,"title":"Benutzer:Sgfdsfsd","missing":""}}}}'PHP Notice: Undefined index: revisions in /home/luke/Cygnus/BotCore.php on line 356
PHP Stack trace:
PHP 1. {main}() /home/luke/Cygnus/Debug.php:0
PHP 2. Debug->__construct() /home/luke/Cygnus/Debug.php:715
PHP 3. Debug->debug() /home/luke/Cygnus/Debug.php:24
PHP 4. Debug->readPage() /home/luke/Cygnus/Debug.php:40
PHP 5. Debug->readPageEngine() /home/luke/Cygnus/BotCore.php:369
Function call succeeded
```Version 2.1Luke081515luke081515@tools.wmflabs.orgLuke081515luke081515@tools.wmflabs.orghttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/71Replace unneeded whiles with for2018-01-13T22:33:44ZLuke081515luke081515@tools.wmflabs.orgReplace unneeded whiles with forwhile's that don't need to be while's should be for.while's that don't need to be while's should be for.Version 2.1Luke081515luke081515@tools.wmflabs.orgLuke081515luke081515@tools.wmflabs.orghttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/63config error at Debug.php2018-01-13T22:33:44ZLuke081515luke081515@tools.wmflabs.orgconfig error at Debug.php```
Starting the function call of movePage...PHP Notice: Undefined offset: 3 in /home/luke/Cygnus/Debug.php on line 223
PHP Stack trace:
PHP 1. {main}() /home/luke/Cygnus/Debug.php:0
PHP 2. Debug->__construct() /home/luke/Cygnus/Debug.php:715
PHP 3. Debug->debug() /home/luke/Cygnus/Debug.php:24
PHP Notice: Undefined offset: 4 in /home/luke/Cygnus/Debug.php on line 223
PHP Stack trace:
PHP 1. {main}() /home/luke/Cygnus/Debug.php:0
PHP 2. Debug->__construct() /home/luke/Cygnus/Debug.php:715
PHP 3. Debug->debug() /home/luke/Cygnus/Debug.php:24
PHP Notice: Undefined offset: 5 in /home/luke/Cygnus/Debug.php on line 223
PHP Stack trace:
PHP 1. {main}() /home/luke/Cygnus/Debug.php:0
PHP 2. Debug->__construct() /home/luke/Cygnus/Debug.php:715
PHP 3. Debug->debug() /home/luke/Cygnus/Debug.php:24
``````
Starting the function call of movePage...PHP Notice: Undefined offset: 3 in /home/luke/Cygnus/Debug.php on line 223
PHP Stack trace:
PHP 1. {main}() /home/luke/Cygnus/Debug.php:0
PHP 2. Debug->__construct() /home/luke/Cygnus/Debug.php:715
PHP 3. Debug->debug() /home/luke/Cygnus/Debug.php:24
PHP Notice: Undefined offset: 4 in /home/luke/Cygnus/Debug.php on line 223
PHP Stack trace:
PHP 1. {main}() /home/luke/Cygnus/Debug.php:0
PHP 2. Debug->__construct() /home/luke/Cygnus/Debug.php:715
PHP 3. Debug->debug() /home/luke/Cygnus/Debug.php:24
PHP Notice: Undefined offset: 5 in /home/luke/Cygnus/Debug.php on line 223
PHP Stack trace:
PHP 1. {main}() /home/luke/Cygnus/Debug.php:0
PHP 2. Debug->__construct() /home/luke/Cygnus/Debug.php:715
PHP 3. Debug->debug() /home/luke/Cygnus/Debug.php:24
```Version 2.1Luke081515luke081515@tools.wmflabs.orgLuke081515luke081515@tools.wmflabs.orghttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/66Debug: better visualisation for null2018-01-13T22:33:44ZLuke081515luke081515@tools.wmflabs.orgDebug: better visualisation for nullIf any functions returns `null` that should get visualized instead of returning an empty row.If any functions returns `null` that should get visualized instead of returning an empty row.Version 2.1Luke081515luke081515@tools.wmflabs.orgLuke081515luke081515@tools.wmflabs.orghttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/60Implement action "rollback"2018-01-13T22:33:44ZLuke081515luke081515@tools.wmflabs.orgImplement action "rollback"It should be possible to rollback a change.It should be possible to rollback a change.Version 2.1Luke081515luke081515@tools.wmflabs.orgLuke081515luke081515@tools.wmflabs.orghttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/25Fix method getLinks2018-01-13T22:33:44ZFreddyFix method getLinksCauses an PHP errorCauses an PHP errorVersion 2.1FreddyFreddyhttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/64params wrongly seperated: movePage2018-01-13T22:33:44ZLuke081515luke081515@tools.wmflabs.orgparams wrongly seperated: movePage```
Result for action=move&format=json&assert=botmaxlag=5&from=Selenium+Echo+link+test+0.7641617008345213+0.7641617008345213&to=Selenium+Echo+link+test+0.7641617008345213+0.764161700834521&reason=test&bot=0&movetalk=0&noredirect=0&token=610ac57ce10bf82c412600dc05b360715a4580de%2B%5C:
'{"error":{"code":"unknown_assert","info":"Unrecognized value for parameter \"assert\": botmaxlag=5.","*":"See https://en.wikipedia.beta.wmflabs.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce> for notice of API deprecations and breaking changes."},"servedby":"deployment-mediawiki05"}'
``````
Result for action=move&format=json&assert=botmaxlag=5&from=Selenium+Echo+link+test+0.7641617008345213+0.7641617008345213&to=Selenium+Echo+link+test+0.7641617008345213+0.764161700834521&reason=test&bot=0&movetalk=0&noredirect=0&token=610ac57ce10bf82c412600dc05b360715a4580de%2B%5C:
'{"error":{"code":"unknown_assert","info":"Unrecognized value for parameter \"assert\": botmaxlag=5.","*":"See https://en.wikipedia.beta.wmflabs.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce> for notice of API deprecations and breaking changes."},"servedby":"deployment-mediawiki05"}'
```Version 2.1Luke081515luke081515@tools.wmflabs.orgLuke081515luke081515@tools.wmflabs.orghttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/65getPageID returns not the pageID2018-01-13T22:33:44ZLuke081515luke081515@tools.wmflabs.orggetPageID returns not the pageIDLooks like it is returning a non-existant variable. A unit test would be nice to prevent that as well.Looks like it is returning a non-existant variable. A unit test would be nice to prevent that as well.Version 2.1Luke081515luke081515@tools.wmflabs.orgLuke081515luke081515@tools.wmflabs.orghttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/68Echo useragent2018-01-05T22:18:39ZLuke081515luke081515@tools.wmflabs.orgEcho useragentTo find your bot at Special:ApiFeatureUsage, you need the useragent, so we should make it easy to find.To find your bot at Special:ApiFeatureUsage, you need the useragent, so we should make it easy to find.Version 2.1Luke081515luke081515@tools.wmflabs.orgLuke081515luke081515@tools.wmflabs.orghttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/44Implement function "rollback"2017-12-30T23:53:26ZLuke081515luke081515@tools.wmflabs.orgImplement function "rollback"Implement a function to use this API-functionImplement a function to use this API-functionVersion 2.1https://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/69checkResult: Handle "protectedpage"2017-12-29T19:07:00ZLuke081515luke081515@tools.wmflabs.orgcheckResult: Handle "protectedpage"`protectedpage` is a common error code, and should get handeled as well.`protectedpage` is a common error code, and should get handeled as well.Version 2.1Luke081515luke081515@tools.wmflabs.orgLuke081515luke081515@tools.wmflabs.orghttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/40Global Methods2017-12-29T01:20:43ZLuke081515luke081515@tools.wmflabs.orgGlobal MethodsNow that we have global block, we should add:
* Global Lock / hide etc.
* Global Userrights
* local userrightsNow that we have global block, we should add:
* Global Lock / hide etc.
* Global Userrights
* local userrightsVersion 2.1Luke081515luke081515@tools.wmflabs.orgLuke081515luke081515@tools.wmflabs.orghttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/42Implement purge2017-12-29T01:20:29ZLuke081515luke081515@tools.wmflabs.orgImplement purgeThe purge API-Function should get implementedThe purge API-Function should get implementedVersion 2.1Luke081515luke081515@tools.wmflabs.orgLuke081515luke081515@tools.wmflabs.orghttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/55Write Readme for Cygnus2017-12-29T01:20:17ZFreddyWrite Readme for CygnusInclude a Readme which describes Cygnus and basic usageInclude a Readme which describes Cygnus and basic usageVersion 2.1Luke081515luke081515@tools.wmflabs.orgLuke081515luke081515@tools.wmflabs.org