|
|
This is our default review workflow:
|
|
|
1. First, merge requests are "At work". You can skip this step if your work is already finished
|
|
|
2. Now, the patch is at "needs testing". A quick test is required for patches, unless you can give a valid reason (typos don't need tests etc.)
|
|
|
3. After that, the patch is at "needs review". Then another person will handle it
|
|
|
4. This person may put the patch to "needs discussion", or assign a CR.
|
|
|
- CR+2 means the patch can get merged, but haven't been merged for some reasons yet (like conflicts). Every person who is able can merge it.
|
|
|
- CR+1 means the patch is ok, but the person who reviewed it would like to have the patch reviewed by another person.
|
|
|
- CR-1 means the idea of patch itself is ok, but the patch has an issue.
|
|
|
- CR-2 means the idea of the patch is bad. |
|
|
\ No newline at end of file |