Cygnus issueshttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues2018-01-30T22:29:41Zhttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/33make the bot able to read/write from wikibase2018-01-30T22:29:41ZLuke081515luke081515@tools.wmflabs.orgmake the bot able to read/write from wikibaseoriginally from https://rcm-2.wmflabs.org/T905
The bot should be able to interact with wikibase. Not sure if we should insert that into BotCore or write a seperate class.originally from https://rcm-2.wmflabs.org/T905
The bot should be able to interact with wikibase. Not sure if we should insert that into BotCore or write a seperate class.FreddyFreddyhttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/81Ban serialized arrays as return value2018-01-12T23:53:10ZLuke081515luke081515@tools.wmflabs.orgBan serialized arrays as return valueSerialized Arrays as return value are bad. The user needs to take care of the API-Answer then. The function should do that for him instead.
Current functions using serialized Arrays:
* [ ] `movePage()`
* [ ] `getCatMembers()`
* [ ] `getPageCats()`
* [ ] `getAllEmbedings()`
* [ ] `getAllPages()`Serialized Arrays as return value are bad. The user needs to take care of the API-Answer then. The function should do that for him instead.
Current functions using serialized Arrays:
* [ ] `movePage()`
* [ ] `getCatMembers()`
* [ ] `getPageCats()`
* [ ] `getAllEmbedings()`
* [ ] `getAllPages()`Version 2.2https://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/28Generate CodeCoverage Report2018-01-10T21:30:29ZLuke081515luke081515@tools.wmflabs.orgGenerate CodeCoverage ReportIt would be nice if pipeline can generate a CodeCoverage report, phpunit supports that, but needs to be configured.It would be nice if pipeline can generate a CodeCoverage report, phpunit supports that, but needs to be configured.Version 2.2https://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/73Write a generic query continue2018-01-09T19:41:46ZLuke081515luke081515@tools.wmflabs.orgWrite a generic query continue!77 inspired me. What do you think of:
**A generic query continue!**
The concept itself is simple and nice, implementation may be not.
# What the function does
## Conditions for using
Query functions often have more results then the limit allows, so continue is needed. Currently the functions are doing this until all results are fetched. This may be useless if the user only needs 7000 for example.
## Calling it
Functions are reciving the continue. This continue has a name as well (if using rawcontinue, we may switch to the other continue), so the continue engine can get called, with the params `continuename `and `api-call url` at least. The function will start fetching everything then. It would be useful to implement that recursive, but PHP allows only 50 levels of recursive functions IIRC
# Nice additional features
The user can specify a limit, and the function tries to fetch as much as possible data, if [limit] > [limit of data to fetch in one request]. Then, the function will continue, until the limit is reached.
Please share your opinion on this proposal with me.!77 inspired me. What do you think of:
**A generic query continue!**
The concept itself is simple and nice, implementation may be not.
# What the function does
## Conditions for using
Query functions often have more results then the limit allows, so continue is needed. Currently the functions are doing this until all results are fetched. This may be useless if the user only needs 7000 for example.
## Calling it
Functions are reciving the continue. This continue has a name as well (if using rawcontinue, we may switch to the other continue), so the continue engine can get called, with the params `continuename `and `api-call url` at least. The function will start fetching everything then. It would be useful to implement that recursive, but PHP allows only 50 levels of recursive functions IIRC
# Nice additional features
The user can specify a limit, and the function tries to fetch as much as possible data, if [limit] > [limit of data to fetch in one request]. Then, the function will continue, until the limit is reached.
Please share your opinion on this proposal with me.Version 2.2https://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/14Write automatic tests for each function2017-11-09T15:12:30ZLuke081515luke081515@tools.wmflabs.orgWrite automatic tests for each functionIt would be great if we can build a script which checks every function against each single return possiblity, and then submit this script to the pipeline for each new commit.It would be great if we can build a script which checks every function against each single return possiblity, and then submit this script to the pipeline for each new commit.Version 2.2Luke081515luke081515@tools.wmflabs.orgLuke081515luke081515@tools.wmflabs.orghttps://gitlab.wmflabs.org/Cygnus/Cygnus/-/issues/32General handling for warnings2017-11-09T14:27:53ZLuke081515luke081515@tools.wmflabs.orgGeneral handling for warningsAs seen in #31 it would be nice if we can display or log warnings. In this case I discovered that problem only because I ran debug with the new verbose-debug mode. That is optimal, as warnings may useful as well for the developers. Additionally, if we are handling warnings better, we can make unit tests fail as well.
What's better, displaying or logging warnings? And at which place to we want to catch them? Each function or maybe httpRequest? httpRequest has the problem of different formats, if old functions are using format=php, httpRequest can't search for the json part. Or implement an extra function for that?
@freddy2001 Your thoughts?As seen in #31 it would be nice if we can display or log warnings. In this case I discovered that problem only because I ran debug with the new verbose-debug mode. That is optimal, as warnings may useful as well for the developers. Additionally, if we are handling warnings better, we can make unit tests fail as well.
What's better, displaying or logging warnings? And at which place to we want to catch them? Each function or maybe httpRequest? httpRequest has the problem of different formats, if old functions are using format=php, httpRequest can't search for the json part. Or implement an extra function for that?
@freddy2001 Your thoughts?Version 2.2FreddyFreddy